sodafoundation / installer

provides easy installation and basic deployment based on specific configurations for SODA Projects
Apache License 2.0
35 stars 68 forks source link

Switching to standard docker-ce #260

Open thatsdone opened 5 years ago

thatsdone commented 5 years ago

Suggestion

Let's use standard docker-ce through docker apt line because opensds must be docker version agnostic, and it's better to use stable and standard ones.

The below procedure gives us docker-ce 19.03.1 now. https://docs.docker.com/install/linux/docker-ce/ubuntu/

Also, let's use the standard docker-compose in Ubuntu bionic repository. Now it gives us docker-compose 1.17.1, it's a bit older than the documentation above. But it looks working (at least for me). If folks don't like this, the latest stable of docker-compose looks like 1.24.1 now, and we can use this instead.

https://github.com/docker/compose/releases/latest

Describe the solution you'd like

Switching to docker-ce and update docker-compose version. Also add an ansible role to install them.

Additional context

At first, I tried Ubuntu 18.04 (bionic) bundled docker-compose(1.17), but I got a trouble regarding compatibility with 'docker-py' thas installed via pip in the playbook. I report this issue separately.

wisererik commented 5 years ago

Hi Itoh-san, Thanks for your suggestion. For docker-ce and docker-compose installation, we follow the docker official document to install docker-ce and docker-compose, please see detail: https://github.com/opensds/opensds/wiki/OpenSDS-Cluster-Installation-through-Ansible. For ubuntu os version, we will test installation on ubuntu bionic version