sodafoundation / installer

provides easy installation and basic deployment based on specific configurations for SODA Projects
Apache License 2.0
35 stars 68 forks source link

[QIP][DAITO] Clean uninstall doesn't stop Dashboard container #330

Closed kumarashit closed 4 years ago

kumarashit commented 4 years ago

Describe the bug If an existing dashboard container is there with different version, cleanup creates new dashboard container (with different image version) but doesn't stop it as other version is already running

To Reproduce Installed OpenSDS from Installer v0.10.0 Removed the dashboard image (though by mistake) Installed "latest" version (dashboard:latest) manually Now executed cleanup of installation Cleanup went fine Installed again Now the dashboard does not comes up as there is another version (latest) already running. But ideally the dashboard v0.10.0 container should go in stopped state.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots TASK [telemetry-uninstaller : clean all created work directories] **** task path: /root/gopath/src/github.com/opensds/opensds-installer/ansible/roles/telemetry-uninstaller/scenarios/clean_telemetry_tools.yml:101 skipping: [localhost] => { "changed": false, "skip_reason": "Conditional result was False", "skipped": true } META: ran handlers META: ran handlers

PLAY RECAP *** localhost : ok=13 changed=10 unreachable=0 failed=0

root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# ansible-playbook site.yml^Ci local.hosts -vvv root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES b99454007fb5 opensdsio/dashboard:v0.10.0 "/bin/sh -c /opt/das…" About a minute ago Created dashboard acca40a16122 opensdsio/dashboard:latest "/bin/sh -c /opt/das…" 8 minutes ago Up 8 minutes opensds-dashboard root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES acca40a16122 opensdsio/dashboard:latest "/bin/sh -c /opt/das…" 8 minutes ago Up 8 minutes opensds-dashboard

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

joseph-v commented 4 years ago

This issue is fixed in PR #332

kumarashit commented 4 years ago

Closing as fixed