sodafoundation / installer

provides easy installation and basic deployment based on specific configurations for SODA Projects
Apache License 2.0
35 stars 68 forks source link

Updated the metric key names in the default Grafana Dashboards as per changes in delfin #438

Closed anvithks closed 3 years ago

anvithks commented 3 years ago

What type of PR is this? /kind enhancement

What this PR does / why we need it: This PR updates the metric key names in the default Grafana dashboards that are installed alongwith the SRM toolchain to match the names of the metrics as per the changes made in Delfin.

Old metric name unit New metric name unit
storage_response_time ms storage_responseTime ms
storage_bandwidth MBs storage_throughput MBs
storage_read_bandwidth MBs storage_readThroughput MBs
storage_write_bandwidth MBs storage_writeThroughput MBs
storage_throughput MBs storage_requests IOPS
storage_read_throughput MBs storage_readRequests IOPS
storage_write_throughput MBs storage_writeRequests IOPS

Which issue(s) this PR fixes:

Fixes #439 439

Test Report Added?: /kind TESTED

Test Report: tested with the latest master branch of Delfin. Overall Performance monitor overall-dashboard-1 overall-dashboard-2 overall-dashboard-3

Storage Details - performance monitor default-dashboard-1 default-dashboard-2 default-dashboard-3

Special notes for your reviewer:

sushanthakumar commented 3 years ago

LGTM