sodafoundation / nbp

NorthBoundPlugins for platforms and clients to connect to SODA Data Framework
Apache License 2.0
51 stars 39 forks source link

Soda NBP for VMware - Tests not comparing observed with expected values #382

Open osiveteam opened 4 years ago

osiveteam commented 4 years ago

The Following Test classes are incomplete as they only perform null check and not the actual comparison of observed vs expected values.


1 OpenSDSTest.java

https://github.com/sodafoundation/nbp/blob/master/vmware/ngc/NGC-AdapterManager/src/test/java/org/opensds/vmware/ngc/adapters/opensds/OpenSDSTest.java

2 NgcregisterApplicationTests.java

https://github.com/sodafoundation/nbp/blob/master/vmware/ngc/NGC-Register/src/test/java/org/opensds/vmware/ngc/NgcregisterApplicationTests.java

3 ConfigurationTest.java
https://github.com/sodafoundation/nbp/blob/master/vmware/vro/plugin/src/test/java/org/opensds/storage/vro/plugin/adapter/opensds/services/ConfigurationTest.java

4 OpenSDSInfoTest.java
https://github.com/sodafoundation/nbp/blob/master/vmware/vro/plugin/src/test/java/org/opensds/storage/vro/plugin/adapter/opensds/services/OpenSDSInfoTest.java

5 VolumeServiceTest.java
https://github.com/sodafoundation/nbp/blob/master/vmware/vro/plugin/src/test/java/org/opensds/storage/vro/plugin/adapter/opensds/services/VolumeServiceTest.java

kumarashit commented 4 years ago

@osiveteam Can you or team help here? We can help to setup the environment

osiveteam commented 4 years ago

@osiveteam Can you or team help here? We can help to setup the environment

Ok Sir, Please advise your availability and share the pre-requisites for us to download and be ready

We basically need the expected values list so that I can do some comparison using assert statements Thanks