search

sodapopcan / vim-twiggy

Git branch management for Vim
280 stars 15 forks source link

buffer stuff #10

Closed yoyoyeti closed 6 years ago

yoyoyeti commented 6 years ago

Maybe found out what was happening with the branches buffer not going away when opening quickhelp.

I think it has something to do with me having "set hidden" in my config which doesn't delete buffers by default. I noticed that in the quickhelp function you were setting bufhidden=delete so I tried it out here and it seems to do the trick. I've never really done any vim plugin stuff or contributed to any public repositories, so let me know if I'm doing anything wrong :) Hopefully this at least helps a little.

Also the issue that this (hopefully) fixes is here: https://github.com/sodapopcan/vim-twiggy/issues/9

sodapopcan commented 6 years ago

Ha, since adding bufhidden=delete to the quickhelp, adding it to the branch buffer has been on my todo list.

So two things regarding this PR:

1) I didn't just go an do this myself since it requires further consideration removing and/or altering other parts (the s:Close() function is where my attention is at).

2) I still want to know exactly why this is happening. I can say for certain that set hidden has nothing to do with it since I have the same setting.

Other than that—even though I'm guilty of similar things in my own commits on this project—I can't accept a PR with a commit message that starts with "Maybe fix" :) If you want to take the reigns and address the above points, please do! I always want to give credit where credit is due. I can certainly answer any questions you have. Otherwise I will take care of it and give you a mention.

yoyoyeti commented 6 years ago

Haha I definitely understand. I'd love to look more into it, but I'm not entirely sure what I'm doing, so I'll definitely hit you up if I get lost. Thanks for the input and I'll see what I can do.