search

soderlind / acf-field-date-time-picker

Date and Time Picker field for Advanced Custom Fields v3 and v4
GNU General Public License v2.0
65 stars 27 forks source link

Picker interface not appearing in repeater field #68

Closed wesleyburden closed 9 years ago

wesleyburden commented 9 years ago

Hi there

I've added this as a comment to your blog so apologies for the double posting.

When the picker is used in a repeater field it doesn't work for added rows. By that I mean once you add a row and click into the input it doesn't show the date picker. I presume this is a bug with the event binding. I did look through the plugin code to try and figure it out but I'm afraid it's a bit advanced for me.

Thanks

wesleyburden commented 9 years ago

Hi again

After further testing it seems to be an incompatibility with ACF Pro 5.1.3. I just tried your picker with 5.0.8 and it worked perfectly. I'll use an older version of ACF Pro for now.

nathansh commented 9 years ago

I'm also having this issue with version 2.0.18.1 of the plugin

nathansh commented 9 years ago

To be exact, I'm using ACF 5.1.3 with 2.0.18.1 of this plugin. The first date picker works, but additional ones aren't instantiated. Probably because the picker element needs to be instantiated inside a $(document).on(...) call.

jpavlicek commented 9 years ago

Took some time to figure it out, but it's a easy change for compatibility with ACF 5.1.5, think it'll work with ACF 5.1.3 also.

Line 39–41 of timepicker.js is: if (input.parents('.acf-row.clone').length) { return; }

It should be for ACF 5.1.5: if (input.parents('.acf-row.acf-clone').length) { return; } There's just a change in the class name.

For compatibility for both variants, this one should work:

if (input.parents('.acf-row.acf-clone').length || input.parents('.acf-row.clone').length) { return; }

nathansh commented 9 years ago

Thanks @jpavlicek. Do you want to do a pull request with this? I could if you're busy and credit you with the fix.

jpavlicek commented 9 years ago

Hey Nathan,

I was really busy before Christmas and will be away because of some christmas dates. I’d do it between Christmas and the new year. So, if you have the time to do it, it would be cool if you do it. Otherwise I’d do it in the next days :-)

All the best, Jonas

Am 23.12.2014 um 04:36 schrieb Nathan Shubert-Harbison notifications@github.com:

Thanks @jpavlicek https://github.com/jpavlicek. Do you want to do a pull request with this? I could if you're busy and credit you with the fix.

— Reply to this email directly or view it on GitHub https://github.com/soderlind/acf-field-date-time-picker/issues/68#issuecomment-67918968.