search

soderlind / read-offline

Read Offline allows you to download or print posts and pages. You can download the post as PDF, ePub and mobi
https://wordpress.org/plugins/read-offline/
31 stars 10 forks source link

Still being developed/supported? #97

Closed mybestrong closed 4 years ago

mybestrong commented 5 years ago

Hi Per

Been using your plugin for such a long while and love it!

I don’t want to stop using it but some errors are now springing up in the logs.

Will you be releasing an update? Even if it’s just to ensure compatibility with the current version of Wordpress?

Best wishes

Rick

soderlind commented 5 years ago

I’ll fix the bugs next week, when I’m back from Thailand

mybestrong commented 5 years ago

That’s amazing Per. Thank you so much!

Rick Wilson

Be Strong UK Ltd

www.mybestrong.com

On 2 Nov 2019, at 11:21, Per Søderlind notifications@github.com wrote:

I’ll fix the bugs next week, when I’m back from Thailand

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

hatmandu commented 5 years ago

Read Offline looks amazing in principle but it's quite broken now, with latest Wordpress. It won't make PDFs or EPUBs for me (lots of error messages); and the version of MOBI is outdated (and doesn't seem to create the TOC correctly). If it's possible to update it it would be fantastic! I haven't seen anything else that offers the same useful features.

hatmandu commented 5 years ago

Aha, I've discovered EPUB does work OK if there's a featured image set - see https://github.com/soderlind/read-offline/issues/86

hatmandu commented 5 years ago

Me again! Some more specific observations:

  1. EPUB doesn't wrap images properly - I've tried a short document with one aligned left and one aligned right - it gets the alignment right but doesn't wrap the text round them at all.
  2. The MOBI creator used doesn't support the current 'enhanced typesetting'; it's not showing a TOC at all for my test; and it doesn't include images or some formatting such as bullet points. Read Offline is still really useful, though, and as I say, I haven't found anything that's better or more elegant to use. Thanks! Andrew
soderlind commented 4 years ago

@hatmandu, could you please test the branch: https://github.com/soderlind/read-offline/tree/upgrade-mpdf-epub ? I've upgraded mpdf and phpepub.

hatmandu commented 4 years ago

Gladly - thanks! (BTW, I think my comment about EPUB above may depend on the Wordpress theme.)

soderlind commented 4 years ago

I'm looking into #86 now.

hatmandu commented 4 years ago

I'm getting these errors for PDF and EPUB (Mobi is fine subject to the issues mentioned above), regardless of featured image:

PDF: Fatal error: Uncaught Mpdf\MpdfException: Unknown page format 1 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php:78 Stack trace: #0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1635): Mpdf\PageFormat::getSizeFromName('1') #1 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1269): Mpdf\Mpdf->_setPageSize('1', 'P') #2 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php(354): Mpdf\Mpdf->__construct(Array) #3 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(97): Read_Offline_Create->pdf(Object(WP_Post)) #4 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP)) #5 /homepages/29/d153541885 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php on line 78

EPUB: Fatal error: Uncaught Error: Class 'PHPePub\Core\EPub' not found in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php:101 Stack trace: #0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(100): Read_Offline_Create->epub(Object(WP_Post)) #1 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP)) #2 /.../wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array) #3 /.../wp-includes/plugin.php(531): WP_Hook->do_action(Array) #4 /.../wp-includes/class-wp.php(387): do_action_ref_array('parse_request', Array) #5 /.../wp-includes/class-wp.php(737): WP->parse_request('') #6 /.../wp-includes/functions.php(1105): WP->main('') #7 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php on line 101

soderlind commented 4 years ago

Do you have one or two versions installed ? wp-content/plugins/read-offline-upgrade-mpdf-epub and wp-content/plugins/read-offline ?

Unknown page format 1 was in the previous version, the one in read-offline-upgrade-mpdf-epubshould fix that. If you've debug enabled for your site, I write the paper_format to wp-content/debug.log: https://github.com/soderlind/read-offline/blob/upgrade-mpdf-epub/inc/class-read-offline-create.php#L341

hatmandu commented 4 years ago

Ah, yeah, I do have both installed, though the original is deactivated. I'll delete it and try again.

hatmandu commented 4 years ago

I have deleted the previous version so only 0.80 is installed - but I get the same errors as above.

hatmandu commented 4 years ago

I tried turning on wp_debug and this is what was recorded...

[13-Nov-2019 19:37:36 UTC] PHP Fatal error: Uncaught Mpdf\MpdfException: Unknown page format 1 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php:78 Stack trace:

0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1635): Mpdf\PageFormat::getSizeFromName('1')

1 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1269): Mpdf\Mpdf->_setPageSize('1', 'P')

2 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php(354): Mpdf\Mpdf->__construct(Array)

3 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(97): Read_Offline_Create->pdf(Object(WP_Post))

4 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP))

5 /homepages/29/d153541885 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php on line 78

[13-Nov-2019 19:37:44 UTC] PHP Fatal error: Uncaught Error: Class 'PHPePub\Core\EPub' not found in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php:101 Stack trace:

0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(100): Read_Offline_Create->epub(Object(WP_Post))

1 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP))

2 /.../wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)

3 /.../wp-includes/plugin.php(531): WP_Hook->do_action(Array)

4 /.../wp-includes/class-wp.php(387): do_action_ref_array('parse_request', Array)

5 /.../wp-includes/class-wp.php(737): WP->parse_request('')

6 /.../wp-includes/functions.php(1105): WP->main('')

7 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php on line 101

mybestrong commented 4 years ago

My PDF’s stopped working last night after years of being ok, albeit with growing error logs.

It’s a huge part of my site and don’t want to change it.

Got up early today to try and sort something.

Is there a new beta version out yet that I could try?

Rick Wilson

Be Strong UK Ltd

www.mybestrong.com

On 13 Nov 2019, at 19:41, hatmandu notifications@github.com wrote:

I tried turning on wp_debug and this is what was recorded...

[13-Nov-2019 19:37:36 UTC] PHP Fatal error: Uncaught Mpdf\MpdfException: Unknown page format 1 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php:78 Stack trace:

0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1635): Mpdf\PageFormat::getSizeFromName('1')

1 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/Mpdf.php(1269): Mpdf\Mpdf->_setPageSize('1', 'P')

2 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php(354): Mpdf\Mpdf->__construct(Array)

3 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(97): Read_Offline_Create->pdf(Object(WP_Post))

4 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP))

5 /homepages/29/d153541885 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/vendor/mpdf/mpdf/src/PageFormat.php on line 78

[13-Nov-2019 19:37:44 UTC] PHP Fatal error: Uncaught Error: Class 'PHPePub\Core\EPub' not found in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php:101 Stack trace:

0 /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-parser.php(100): Read_Offline_Create->epub(Object(WP_Post))

1 /.../wp-includes/class-wp-hook.php(286): Read_Offline_Parser->parse_request(Object(WP))

2 /.../wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)

3 /.../wp-includes/plugin.php(531): WP_Hook->do_action(Array)

4 /.../wp-includes/class-wp.php(387): do_action_ref_array('parse_request', Array)

5 /.../wp-includes/class-wp.php(737): WP->parse_request('')

6 /.../wp-includes/functions.php(1105): WP->main('')

7 in /.../wp-content/plugins/read-offline-upgrade-mpdf-epub/inc/class-read-offline-create.php on line 101

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mybestrong commented 4 years ago

However! I learned it was a conflict with another plugin! Deleted that and I’m back up and running 😊👍

soderlind commented 4 years ago

@mybestrong, what's the name of the conflicting plugin ?

mybestrong commented 4 years ago

Hi Per

It was HurryTimer.

Regards

Rick

Rick Wilson

Be Strong UK Ltd

www.mybestrong.com

On 24 Nov 2019, at 00:23, Per Søderlind notifications@github.com wrote:

@mybestrong, what's the name of the conflicting plugin ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mybestrong commented 4 years ago

@soderlind I hope that you're well and keeping safe.

Do you still have plans to update this brilliant plugin? Its getting to the point where I might need to look for an alternative solution and I really don't want to do that :(

hatmandu commented 4 years ago

Hi there - I'd like to second Rick's question. I still haven't found any plugin that does what this one does (or would, if it still worked!) in the same useful, elegant way. (Funnily enough I'm in the UK too.) I'd be willing to make a donation to support the development of it. At the moment it doesn't work for PDFs at all for me, and the MOBI output is limited when it works. The EPUB output does work - though unfortunately the files created, although usable, don't validate with epubcheck. Is there anything you can do, Per? Thanks! Andrew

soderlind commented 4 years ago

I've updated the plugin, please test