sodiray / radash

Functional utility library - modern, simple, typed, powerful
https://radash-docs.vercel.app
MIT License
4.18k stars 167 forks source link

Add correct handling of non string, number or symbol values to unique #343

Open jordydhoker opened 1 year ago

jordydhoker commented 1 year ago

Description

The issue should be clear enough: https://github.com/rayepps/radash/issues/342

Checklist

Resolves #342

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 2:24am
sodiray commented 6 months ago

Hey @jordydhoker thanks for the PR 👍 I'm curious what your use case is? I'm not sure the ability to use non-primitive values as identifies is worth using a map. I think this change could lead to devs 'shooting themselves in the foot' if they have the ability to use any value for the identity/equality.