search

sodium-friends / sodium-javascript

Pure Javascript version of sodium-native
MIT License
92 stars 24 forks source link

Return 0 from crypto_sign_keypair for unit tests #50

Closed RangerMauve closed 4 years ago

RangerMauve commented 4 years ago

Noticed that tests were failing on this line in sodium-test due to crypto_sign_keypair and crypto_sign_seed_keypair not returning 0

mafintosh commented 4 years ago

@chm-diederichs didn't we change this somewhere?

mafintosh commented 4 years ago

Actually, I think you are just on an older test version? It's working fine in master at least atm https://travis-ci.org/github/sodium-friends/sodium-javascript/builds/734261875

chm-diederichs commented 4 years ago

Yeh this test was changed in v0.10.0 as functions no longer return integer flags since v0.7.0, now they either return booleans or throw on error.

See https://github.com/sodium-friends/sodium-javascript/issues/34 for more info

RangerMauve commented 4 years ago

Sweet thank you, I didn't notice the change.