search

soduto / Soduto

Soduto is a KDEConnect compatible client for macOS. It allows better integration between your phones, desktops and tablets.
https://www.soduto.com
GNU General Public License v3.0
319 stars 49 forks source link

Always show battery percentage or give an option to show it #10

Open alexanderadam opened 3 years ago

alexanderadam commented 3 years ago

It would be great if percentage of the battery could also be shown before the name of the device.

PS: Thank you so much for Soduto :+1:

Ashinch commented 3 years ago

You can check out my fork.

alexanderadam commented 3 years ago

You can check out my fork.

Are you planning on doing a pull request?

Ashinch commented 3 years ago

I'm not sure if I will pull request, because this project has been out of maintenance for a long time, and the author may not want to merge it. But I have completed this function in my repo, but the library of this project is too old to be bundle for you on my new macOS. If you understand build it, you can go to my fork branch to get the source code.

alexanderadam commented 3 years ago

I'm not sure if I will pull request, because this project has been out of maintenance for a long time, and the author may not want to merge it.

I'm sure that @giedrius-stanevicius will consider it. The README was just updated in February this year.

If you understand build it, you can go to my fork branch to get the source code.

I really don't. :laughing:

Ashinch commented 3 years ago

Ok. I will try to pull request. If you are using KDE-Connect for Android, you can also check out my fork repo. It has some interesting extra features and has released an apk.

alexanderadam commented 3 years ago

Ok. I will try to pull request.

Great :+1:

If you are using KDE-Connect for Android, you can also check out my fork repo. It has some interesting extra features and has released an apk.

I do. But I really don't want to have struggles regarding updates. That's why I'm always using the standard packages of F-Droid. But maybe you should consider doing PRs for these patches as well? :wink:

giedrius-stanevicius commented 3 years ago

Hey there, @Ashinch ! I would gladly accept your changes into the project. Just want to notice several things about your changes. First, I think there should be two separate pull request as there are two separate features updated: the battery indicator and the notifications service.

The battery indicator part looks mostly ok, only not sure about the device name and battery status placement - as in the changed version there is text for the battery status and text for device name and they get somewhat merged into one with no clear separation. Maybe battery status at the right side of menu could look better and more in line with native macOS battery status display:

Screenshot 2021-06-19 at 00 29 17

Regarding the activation of notifications service - well it was disabled deliberately as I considered it to be not finished. While it works, it might get quite noisy and I wanted to give users some means to control what types of notifications and when to show. On the other hand, I recognize that the feature could be useful even in the current state, so I don't object to the change in general. However, I'd like that the service could be easily switched on or off. A nice option would be to add a checkbox to the settings UI. A simpler option - add a compile time flag to enable the feature (default should be off).

Ashinch commented 3 years ago

Hi @giedrius-stanevicius , thank you for your reply, I will separate and organize the battery part later.

Ashinch commented 3 years ago

Hey ! @giedrius-stanevicius

The battery indicator part looks mostly ok, only not sure about the device name and battery status placement - as in the changed version there is text for the battery status and text for device name and they get somewhat merged into one with no clear separation. Maybe battery status at the right side of menu could look better and more in line with native macOS battery status display:

I have a question. If the battery indicator moves to the right, it may be blocked when the device name is too long, and the battery icon may also move to the right with the text?

How do you think about this question?

giedrius-stanevicius commented 3 years ago

I think battery icon and percentage text should be near each other.

Regarding the placement on the right - well I am not that experienced at macOS UI programming. I guess a custom view would need to be used in this case. Here are some possibly useful links I found:

Not sure whether such custom menus would show arrows for submenus easily, thought. This might complicate things even more.