soduto / Soduto

Soduto is a KDEConnect compatible client for macOS. It allows better integration between your phones, desktops and tablets.
https://www.soduto.com
GNU General Public License v3.0
319 stars 49 forks source link

No visual or auditory notification of file upload #28

Open ballo opened 1 year ago

ballo commented 1 year ago

It's great that soduto supports file uploading, but there is no notification it ever occurred. How about when a file is finished uploading I get a (temporary) system notification?

sannidhyaroy commented 1 year ago

Soduto supports file share status notifications but since this project has been not been in active development for years, you may notice some features not working if you're running a newer version of macOS. The notification system has been particularly affected as NSUserNotification has been deprecated and UNUserNotification object is recommended for sending notifications. I have tried removing dead or deprecated code because I'm an active user of Soduto. You may check out the Nightly Version of Soduto that I released in my fork if you're comfortable working on an unofficial build of the app.

ballo commented 1 year ago

Soduto supports file share status notifications but since this project has been not been in active development for years, you may notice some features not working if you're running a newer version of macOS. The notification system has been particularly affected as NSUserNotification has been deprecated and UNUserNotification object is recommended for sending notifications. I have tried removing dead or deprecated code because I'm an active user of Soduto. You may check out the Nightly Version of Soduto that I released in my fork if you're comfortable working on an unofficial build of the app.

Hey, I appreciate the effort, but I tried your nightly and I don't see any difference in behavior.

sannidhyaroy commented 1 year ago

Hey, I appreciate the effort, but I tried your nightly and I don't see any difference in behavior.

You mean you still don’t get notifications when you try to send a file to another device? It's expected to show a notification when the sharing starts and another one to notify when the sharing is successful or unsuccessful. If this isn't working for you, can you clean install Soduto. Ensure that you unpair your devices, then remove Soduto and it's leftovers using AppCleaner and CleanMyMacX and then delete all keys associated to Soduto from the Keychain app and then perform a clean re-install.

ballo commented 1 year ago

I get no notification. To be clear I'm 'sharing' a file to KDE Connect on the Android (initiating the transfer on the phone, NOT the Mac)

sannidhyaroy commented 1 year ago

I get no notification. To be clear I'm 'sharing' a file to KDE Connect on the Android (initiating the transfer on the phone, NOT the Mac)

Well, in my case when I initiate the transfer from Zorin Connect (android) to Soduto (macOS), I get a notification on my mac which says, "Receiving file from device" and when the transfer completes successfully, it removes the previous notification and sends another notification which says "File Received" with additional details about the file name and location. This notification will stay for 5 seconds and then go away automatically.

Which version of macOS and Soduto are you on?

ballo commented 1 year ago

Never heard of Zorin Connect.

I'm using Monterey (unfortunately) and Soduto 1.1.2 (15)

sannidhyaroy commented 1 year ago

Never heard of Zorin Connect.

I'm using Monterey (unfortunately) and Soduto 1.1.2 (15)

Unfortunately, I can't give you a proper solution or fix the code if necessary, unless I can replicate your issue. If possible, please try to reinstall Soduto and remove it's leftover files and keys from Keychain and Finder. Also, if you're using KDE Connect, try using Zorin Connect to make sure it's not a problem with KDE Connect in the first place. Take a look if you're SHA keys are valid and verify if Soduto has all the necessary notification permissions...

My setup: Soduto v2.0.0 Nightly (Build 17) and Zorin Connect 1.23.2

ballo commented 1 year ago

I just tried Zorin Connect (deleting KDE Connect) and Soduto no longer sees the divice. It doesn't appear to work at all. Perhaps this is because I don't use "WiFi" on the phone but instead mobile hotspot (which works fine with KDE Connect) I don't know.

Anyway, Zorin is a complete dud.

ballo commented 1 year ago

I also found the 2.0.0 (17) version and installed it. Still no notifications.

ballo commented 1 year ago

2.0.1 (18) no notifications

sannidhyaroy commented 12 months ago

2.0.1 (18) no notifications

There was bug with notification permissions that has been fixed on June 16th where Soduto wouldn’t explicitly request for notification permissions, if it wasn’t authorized to push notifications by macOS. However another release haven’t been made yet after this commit was pushed as of now. Could you go to System Preferences > Notifications and then try to find Soduto in the list? If you can’t find it, that explains why you're not getting notifications.

Also, this is the official repo of Soduto and since your using my forked version of Soduto, it's better to open your issue in my repo, since this is not related to the official version of Soduto. It would also help me keep track of the open issues of my fork.

ballo commented 11 months ago

Do I have to manually add it?

ballo commented 11 months ago

OK, just now Soduto prompted to install an update. After the update it showed up in System Preferences/Notifications for the first time. I had to enable it from there but now, for the first time ever for me, Notifications are working 🙂

ballo commented 11 months ago

Do I always have to manually dismiss them or does it just mirror the android status?

sannidhyaroy commented 11 months ago

Do I always have to manually dismiss them or does it just mirror the android status?

There are two ways to dismiss notifications in macOS. If you just tap the cross button, it'll dismiss them only on your mac but if you click on the action button labeled "Dismiss", then the notification will be dismissed on both the devices.

In the android side, if you dismiss a notification, it'll also dismiss on macOS.

ballo commented 11 months ago

Nice. Thank you!