soedinglab / ffindex_soedinglab

Other
16 stars 2 forks source link

Separate git repo for mpq library? #6

Open smoe opened 6 years ago

smoe commented 6 years ago

Hello,

while compiling hhsuite with openmpi installed, I ran into an error because of a missing mpq library that you ship with ffindex. I then quickly deinstalled openmpi, but the better approach may be to offer the header file and the library to link against. Would you accept a patch against ffindex to create respective library? Or is there another git repository for mpq out there somewhere? Should there be one? In https://github.com/soedinglab/ffindex_soedinglab/issues/4 I already learned that you treat ffindex as a git subproject, which completely explains why you don't run into any such issue on your side since you have everything in one tree. But the users of yours who compile from your hhsuite release source tree will notice since ffindex is then external to that tree, which is just the right way how it should be for the redistribution. Just, somehow, mpq is a bit lost.

Cheers,

Steffen

ZivBA commented 3 years ago

I confirm this is still happening. Any chance of adding the MPQ library to hhsuite tree as well?