Segmentation faults and wrong hits from HHblits due to indexing error in ss_score

soedinglab / hh-suite

Remote protein homology detection suite.

https://bmcbioinformatics.biomedcentral.com/articles/10.1186/s12859-019-3019-7

GNU General Public License v3.0

529 stars 133 forks source link

Segmentation faults and wrong hits from HHblits due to indexing error in ss_score #193

Closed dvs closed 4 years ago

dvs commented 4 years ago

Hi Everyone,

I think I found an indexing error in hhviterbialgorithm.cpp which results in either SEGFAULT or wrong hits (hits with score > 100000). The error occurs only when more than one iteration is performed (-n 2,3,4) and even then it's stochastic, i.e. some test runs are successful. See the attached archive where I show how to reproduce the error (PfamA v.31 is needed). It also contains my patch which fixes the error.

Thanks for the fantastic HH-Suite!

Best, Dmitry

dvs commented 4 years ago

P.S. The test script, data, and the patch: ss-score-bugreport.tar.gz