soedinglab / hh-suite

Remote protein homology detection suite.
https://bmcbioinformatics.biomedcentral.com/articles/10.1186/s12859-019-3019-7
GNU General Public License v3.0
515 stars 128 forks source link

hhsearch segmentation fault #275

Closed ajrferrari closed 3 years ago

ajrferrari commented 3 years ago

I am running hhsearch (HHsearch 3.3.0) with the following parameters

CPU="10" MEM="12" DB="$PIPEDIR/pdb100_2020Mar11/pdb100_2020Mar11"

HH="$softwares/hh-suite/build/bin/hhsearch -b 50 -B 500 -z 50 -Z 500 -mact 0.05 -cpu $CPU -maxmem $MEM -aliw 100000 -e 100 -p 5.0 -d $DB"

$HH -i $WDIR/t000.msa0.ss2.a3m -o $WDIR/t000.hhr

This is the log file which states there is a segmentation fault happening

Segmentation fault (core dumped)

See attached the t000.msa0.ss2.a3m.gz [t000.msa0.ss2.a3m.gz](https://github.com/soedinglab/hh-suite/files/6760244/t000_.msa0.ss2.a3m.gz) file.

I'm running the source github code I just have installed. The same error was happening from the conda version. Any help on this?

milot-mirdita commented 3 years ago

Please run the hhsearch in gdb:

gdb --args $HH -i $WDIR/t000_.msa0.ss2.a3m -o $WDIR/t000_.hhr

Then press r (run) and enter and then once it crashes bt (backtrace) and enter. Copy paste the output here please.

ajrferrari commented 3 years ago

Hi Milot,

Here is the output (same for conda and built from source versions)

0 0x00005555555e3d6c in HHDatabaseEntry::getTemplateA3M(Parameters&,

float, float const () [20], float const (*) [20], Alignment&) ()

1 0x0000555555575372 in HHblits::mergeHitsToQuery(HitList&, Hash*,

Hash*, int&, int&, int) ()

2 0x000055555557e482 in HHblits::premerge(Hash, Hash, int&,

int&, int) ()

3 0x0000555555580dba in HHblits::run(_IO_FILE, char) ()

4 0x00005555555703dd in main ()

On Sun, Jul 4, 2021 at 5:44 PM Milot Mirdita @.***> wrote:

Please run the hhsearch in gdb:

gdb --args $HH -i $WDIR/t000.msa0.ss2.a3m -o $WDIR/t000.hhr

Then press r (run) and enter and then once it crashes bt (backtrace) and enter. Copy paste the output here please.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/0a05055b956bb7b708ae8f20510812737a58a19c?url=https%3A%2F%2Fgithub.com%2Fsoedinglab%2Fhh-suite%2Fissues%2F275%23issuecomment-873676643&userId=1579673&signature=45c4c960ae8e093a, or unsubscribe https://mailtrack.io/trace/link/b95165d2355f29818af489c4460754f12631ac55?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFZL64IGTNF2BHKRPYJNLVTTWDP3HANCNFSM47ZK6HYA&userId=1579673&signature=62d9ce3603355b38 .

-- Állan

jiaxiang-wu commented 3 years ago

Hi @ajrferrari

Are you using the RoseTTAFold repo from RosettaCommons? I have encountered the same segmentation fault issue when running hhsearch. Downgrading hh-suite from v3.3.0 to v3.2.0 works for me (compiling from source). Maybe you can also give it a try.

Best,

martin-steinegger commented 3 years ago

@jiaxiang-wu @ajrferrari we added the pre-merge back to HHblits. It looks like this is causing the issues. You can avoid using the premerge by setting -premerge to 0.

jiaxiang-wu commented 3 years ago

@martin-steinegger Got it! Thanks for your reply!

martin-steinegger commented 3 years ago

I have looked at the issues. It seems that the PDB100 database does not contain an _a3m database. HHblits requires it to load sequences for the premerge. I would contact the Baker group and ask to add the a3m files.

ajrferrari commented 3 years ago

@jiaxiang-wu @martin-steinegger I tried to run it with the -premerge 0 flag but it returned the same error.

gdb --args $HH -i $WDIR/t000.msa0.ss2.a3m -o $WDIR/t000.hhr -premerge 0

0x000000000047f304 in HHDatabaseEntry::getTemplateA3M(Parameters&, float, float const () [20], float const (*) [20], Alignment&) () (gdb) bt

0 0x000000000047f304 in HHDatabaseEntry::getTemplateA3M(Parameters&,

float, float const () [20], float const (*) [20], Alignment&) ()

1 0x000000000041e63a in HHblits::mergeHitsToQuery(HitList&, Hash*,

Hash*, int&, int&, int) ()

2 0x000000000042487f in HHblits::premerge(Hash, Hash, int&,

int&, int) ()

3 0x00000000004273ee in HHblits::run(_IO_FILE, char) ()

4 0x0000000000419b2d in main ()

Meanwhile, I also ask them for the _a3m database to be included in the PDB100.

On Mon, Jul 5, 2021 at 1:58 AM Martin Steinegger @.***> wrote:

I have looked at the issues. It seems that the PDB100 database does not contain an _a3m database. HHblits requires it to load sequences for the premerge. I would contact the Baker group and ask to add the a3m files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/6791318b63093404187562f35b8844dd832cbc5e?url=https%3A%2F%2Fgithub.com%2Fsoedinglab%2Fhh-suite%2Fissues%2F275%23issuecomment-873855448&userId=1579673&signature=582e956537eb6a4f, or unsubscribe https://mailtrack.io/trace/link/17a1d4000399c4f2fe0639c4e3cfda898551fea6?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFZL64PKWIK3HNJWC3HZIBDTWFJ3BANCNFSM47ZK6HYA&userId=1579673&signature=0409e9ca10c3668b .

-- Állan

milot-mirdita commented 3 years ago

Please pull the latest commit again and recompile. -premerge was only parsed in hhblits.

milot-mirdita commented 3 years ago

We will make a new release soon, there were quite a few important bug fixes since the last release.

ajrferrari commented 3 years ago

Thank you, @milot-mirdita, it worked! Waiting for the new release!

moonblue333 commented 3 years ago

This is OK for me. (context: RosettaCommons/RoseTTAFold) wget https://github.com/soedinglab/hh-suite/releases/download/v3.2.0/hhsuite-3.2.0-AVX2-Linux.tar.gz --no-check-certificate tar xvfz hhsuite-3.2.0-AVX2-Linux.tar.gz

ksteczk commented 2 years ago

We will make a new release soon, there were quite a few important bug fixes since the last release.

Just for making longer plans, I'd like to ask whether a new release is planned or all bug fixes were already included and we're good to go with the current version? Do you plan any substantial changes in the functioning of the programs (eg. ffindex stuff) or everything will stay as it is?