soedinglab / prosstt

PRObabilistic Simulations of ScRNA-seq Tree-like Topologies
http://dx.doi.org/10.1093/bioinformatics/btz078
GNU General Public License v3.0
25 stars 11 forks source link

Add simple pip install, newick dependency and fix minimal example imports #4

Closed scottgigante closed 6 years ago

scottgigante commented 6 years ago

Hi! Thanks for your work on PROSSTT. I've made a couple of changes which I think improve the setup and tutorial experience.

scottgigante commented 6 years ago

I've also replaced the sys.exit in simulation.py with a raise ValueError - it's not very friendly to quit my python interpreter because I did something wrong :)

scottgigante commented 6 years ago

I've also removed the statement about python2 support - https://github.com/soedinglab/prosstt/blob/27c2796d543d94756319a257bf785bc0dfa00799/prosstt/simulation.py#L111 is one example of where Python2 will silently give the wrong results, as Python2 has the following behaviour:

>>> steps = 5
>>> 2 / steps
0
scottgigante commented 6 years ago

I've added another change: tree.Tree.simulate_lineage corrected the genes, not the modules, to the parent - the modules should be corrected instead so they reflect the true gene programs.

galicae commented 6 years ago

Thanks for the suggestions, Scott! Will look into that ASAP and let you know.

galicae commented 6 years ago

Ok, back from vacation and on a real computer again :smile: Thanks for catching these!

scottgigante commented 6 years ago

You're welcome! 😄