soegaard / sketching

A Racket library for creative drawings and animations. Inspired by Processing.
111 stars 10 forks source link

unhex uses base 2 instead of base 16 #63

Closed Ecsodikas closed 2 years ago

Ecsodikas commented 2 years ago

While playing around with some functions I found out that unhex is not behaving as it should. It treats the input as base 2 instead of base 16.

Ecsodikas commented 2 years ago

Fixing this is trivial, so I did it. But I don't know if I have to change something for the documentation because my pull requests always fail the workflow runs.

soegaard commented 2 years ago

I need to look at the automatic workflow.

Currently it both builds the documentation and copies to soegaard.github.io. Presumably the documentation build fine. I am guessing, the error you see is a permission error - Github allows only me to actually copy the resulting html files to soegaard.github.io.

I'll need to change the workflow, so it just builds the documentation. And then make a new workflow, that only copies.

Thanks for finding the error.

soegaard commented 2 years ago

If you click on the check, you will see:

image

Only the deploy (copying) step failed, so your fix is fine.