search

soegaard / whalesong

Whalesong: Racket to JavaScript compiler
http://hashcollision.org/whalesong
145 stars 14 forks source link

add support for on-release in big-bang #4

Closed darrencruse closed 9 years ago

darrencruse commented 9 years ago

Hi I tried your branch of whalesong with this pong game I'd written: https://github.com/darrencruse/pong-world-racket

It went pretty well but controlling the paddles really was painful without support for key "on-release" so I went ahead and added it.

I think it's a pretty straightforward change imitating the way that "on-key" already worked.

You can see it working for real here:

http://htmlpreview.github.io/?https://github.com/darrencruse/pong-world-racket/blob/master/whalesong/build/pong-world.html

Darren

soegaard commented 9 years ago

Hi Darren,

Thanks for the pull request. It looks fine.

Could I persuade you to add a paragraph on on-release in the Scribble documentation?

/Jens Axel

darrencruse commented 9 years ago

Hi Jens no problem I'll add a paragraph.

I'm not at my computer will it be obvious which file I should edit I'm not remembering the Scribble docs (I'm a little new to racket btw) On Jan 2, 2015 5:31 AM, "Jens Axel Søgaard" notifications@github.com wrote:

Hi Darren,

Thanks for the pull request. It looks fine.

Could I persuade you to add a paragraph on on-release in the Scribble documentation?

/Jens Axel

— Reply to this email directly or view it on GitHub https://github.com/soegaard/whalesong/pull/4#issuecomment-68520904.

soegaard commented 9 years ago

Great. It is this file: https://github.com/soegaard/whalesong/blob/master/whalesong/scribblings/manual.scrbl

2015-01-03 1:16 GMT+01:00 Darren Cruse notifications@github.com:

Hi Jens no problem I'll add a paragraph.

I'm not at my computer will it be obvious which file I should edit I'm not remembering the Scribble docs (I'm a little new to racket btw) On Jan 2, 2015 5:31 AM, "Jens Axel Søgaard" notifications@github.com wrote:

Hi Darren,

Thanks for the pull request. It looks fine.

Could I persuade you to add a paragraph on on-release in the Scribble documentation?

/Jens Axel

— Reply to this email directly or view it on GitHub https://github.com/soegaard/whalesong/pull/4#issuecomment-68520904.

— Reply to this email directly or view it on GitHub https://github.com/soegaard/whalesong/pull/4#issuecomment-68575304.

Jens Axel Søgaard