search

soen / Conjunction

A Sitecore utility designed to create configurable and personalizable queries for either the Lucene or Solr search engine using Sitecore's ContentSearch API
https://soen.github.io/Conjunction
MIT License
12 stars 1 forks source link

Move Sitecore specific code out of the Conjunction.Foundation.Core assembly #26

Closed soen closed 7 years ago

soen commented 7 years ago

Do you want to request a feature or report a bug? Feature/Change.

What is the current behavior? Currently, the core assembly of Conjunction Conjunction.Foundation.Core contains both abstract interfaces and generic implementation details, as well as Sitecore specific implementation details.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem N/A

What is the expected behavior? The core assembly should be split into two separate assemblies, whereas the existing Conjunction.Foundation.Core assembly only contains abstract interfaces and generic implementation details. Likewise, a new assembly (could be named Conjunction.Foundation.Sitecore) should exist, which should contain all the concrete implementation details in the context of using Sitecore - this assembly will be dependant on the Conjunction.Foundation.Core assembly.

What is the motivation / use case for changing the behavior? In its current state, the Conjunction.Foundation.Core assembly is tightly coupled together with Sitecore specific implementation details. This makes it hard to reuse the true "core" parts of the Conjunction.Foundation.Core assembly in a different context.

Which versions of Conjunction is affected by this issue? Did this work in previous versions of Conjunction? Current production and development version is affected.

Other information (e.g. stacktraces, related issues, suggestions how to fix) N/A