soen / Conjunction

A Sitecore utility designed to create configurable and personalizable queries for either the Lucene or Solr search engine using Sitecore's ContentSearch API
https://soen.github.io/Conjunction
MIT License
12 stars 1 forks source link

Separation of Core- and domain specific parts #27

Closed soen closed 7 years ago

soen commented 7 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) A restructure of the Conjunction codebase seperating the Sitecore specific parts from the pure Core parts.

What is the current behavior? (You can also link to an open issue here) See issue #26 for more information.

What is the new behavior (if this is a feature change)? The core assembly is split into two separate assemblies:

whereas the Conjunction.Core assembly only contains abstract interfaces and generic implementation details. Likewise, the assembly named Conjunction.Sitecore contains all the concrete implementation details in the context of using Sitecore - this assembly is dependant on the Conjunction.Core assembly.

Does this PR introduce a breaking change? Yes, comsumers of the API will have to include both the Conjunction.Core and Conjunction.Sitecore assemblies, instead of just Conjunction.Foundation.Core.

Please check if the PR fulfills these requirements

Other information: The docs will be updated in a later PR, which address updating docs in general for vNext.