search

soenkehahn / cradle

Rust library for running child processes
Creative Commons Zero v1.0 Universal
38 stars 5 forks source link

Allow to implement custom impls for `Input` #175

Closed soenkehahn closed 3 years ago

soenkehahn commented 3 years ago

One open question: Currently the configure methods in the Input impls are all #[doc(hidden)]. Which makes some sense, since users are usually not going to call those. But since the method is unhidden in the trait now, maybe we should also unhide the impl methods?

Update: I just tried to unhide configure in the impls and it causes the doc comments for the impls to be collapsed. So you have to click a little + to see them (and the configure method). So I think that would be worse.

casey commented 3 years ago

The new example is simple and concrete, but the motivation isn't clear to me. The podman example had a gotcha, but it was clearer why it would be useful. But maybe the new example is fine, since it does demonstrate how to write custom Input implementations.

casey commented 3 years ago

Nice, LGTM