search

soenkehahn / generics-eot

A library for generic programming that aims to be easy to understand
https://generics-eot.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 6 forks source link

use Void from `base` #12

Closed soenkehahn closed 6 years ago

dalaing commented 6 years ago

Looks good to me. Maybe consider adding void to package.yaml and generics-eot.cabal? That'll take care of the version management so that generics-eot works with version of GHC both before and after when Void was added to base.

soenkehahn commented 6 years ago

@dalaing: Thanks for the review. Currently only ghc-7.10 and ghc-8.0 are tested on CI, so I assumed that this package wouldn't work on ghc-7.8 and below. Especially since GHC.Generics -- which this package uses -- changed a bit between these ghc versions. I think. So I don't want to add a dependency on the package void just on the chance that this might make generics-eot work for older compiler versions.

I've created #16, which is somewhat related.