support ghc-8.4 - Githubissues

soenkehahn commented 6 years ago

@harendra-kumar: Thanks for reporting this. Could you confirm that this fixes #56 for you? If you do, I'll make a release to hackage.

I'd also appreciate a review, if you're up for that. Some comments:

I've removed the Monoid instance, since that was the easiest way to support all compilers (7.8 - 8.4). (Another option would've been to depend on semigroup which works on all those compiler versions, but that would mean to add the transitive dependency of text without actually using that package. Which sounds like a bad idea.)
The Flag type is internal, so removing the instance shouldn't matter to library users.
This would only require a patch-level version bump. (Especially here I'd appreciate a second opinion.)

harendra-kumar commented 6 years ago

I took a look at the changes. Looks good to me. There is no user visible impact so patch level bump should be fine. Let me try this on my repo.

harendra-kumar commented 6 years ago

It worked for me! Thanks! Please upload to hackage.

soenkehahn commented 6 years ago

Released as 0.13.0.2. Thanks a lot for the review, @harendra-kumar!

harendra-kumar commented 6 years ago

@soenkehahn thanks for writing and maintaining this cool package!

soenkehahn / getopt-generics