search

sofa-framework / SofaQtQuick

6 stars 10 forks source link

Bring the work of SofaDefrost team on the official SofaQtQuick repository #34

Open Ant0nin opened 5 years ago

Ant0nin commented 5 years ago

I am personally an everyday user of SofaQtQuick and I figured out that a lot of work has been done onto the next-gen GUI thanks to the Defrost team, especially @damienmarchal and @marques-bruno . For these reasons, I suggest to merge their "dev" branch onto the "master" branch of the official SofaQtQuick repository. Moreover, it seems that the merge can be performed in a fast-forward way so easy to do. What you guys do you think about?

damienmarchal commented 5 years ago

This will break everyone's code as the dev branch involve major refactoring nearly everywhere.

marques-bruno commented 5 years ago

I'd say it couldn't hurt to merge it in a dev branch or experimental branch on sofa-framework if people are interested to try it out and contribute to it, although that could be done through the SofaDefrost fork too. Our fork contains a lot of new contributions, that's true, but it also breaks a lot of stuff that were more or less working before, and there's been no attention dedicated to performances on our side so far... :)

Ant0nin commented 5 years ago

@damienmarchal OK I didn't know that. @marques-bruno I think that merging onto a dev branch of sofa-framework is a good idea. I already tried to contribute on SofaQtQuick ( see my PRs at https://github.com/sofa-framework/SofaQtQuick/pulls ) and I'll be glad to continue. Otherwise I can also directly use the dev branch of SofaDefrost repository if it is more convenient for you, and (re-)create my PRs on it.

BehnamBinesh commented 4 years ago

Hi i got this pull request for building SofaQtQuick app i have many cmake error can you give me a doc for cmake and build

Info :: cmake version :: 3.16.3 Os :: Ubuntu 18.04 Sofa Version :: Latest Source Code From Master Branch