sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
871 stars 297 forks source link

[plugins] Add BeamAdapter as a new plugin #2890

Closed hugtalbot closed 1 year ago

hugtalbot commented 2 years ago

BeamAdapter shall now be fetchable from SOFA CMake configuration


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

guparan commented 2 years ago

@hugtalbot To be enabled on CI ? I'm pretty confident for BeamAdapter but not for Caribou.

hugtalbot commented 2 years ago

@guparan yes for BA, since I will remove Caribou from this PR this answers your question :)

guparan commented 2 years ago

[ci-build][with-all-tests]

guparan commented 2 years ago

https://www.sofa-framework.org/dash/?branch=origin/PR-2890 :fire: :fire: :fire: :fire: :fire: :fire: :fire:

hugtalbot commented 2 years ago

It appears that Damien anticipated it: https://github.com/sofa-framework/BeamAdapter/pull/11

[ci-build][with-all-tests]

alxbilger commented 2 years ago

Still some compilation errors left

hugtalbot commented 1 year ago

hey @guparan @alxbilger after investigation, the problem is the same than the one identified in #2927 the lib is generated in build/applications/plugins/BeamAdapter/lib/ and no example from BeamAdapter is also available moreover, when I do ninja install only BeamAdapter get installed in its own location (build/applications/plugins/BeamAdapter/linstall/)

do you have any idea what's going on @guparan ?

guparan commented 1 year ago

Here is the fix: https://github.com/SofaDefrost/SoftRobots/pull/147

hugtalbot commented 1 year ago

[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/12]

hugtalbot commented 1 year ago

[ci-build][with-all-tests]

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

hugtalbot commented 1 year ago

[ci-build][force-full-build][with-all-tests]

hugtalbot commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

hugtalbot commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #14.

To unlock the merge button, you must

hugtalbot commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #15.

To unlock the merge button, you must

fredroy commented 1 year ago

[ci-build][force-full-build]

sofabot commented 1 year ago

[ci-depends-on] detected during build #16.

To unlock the merge button, you must

fredroy commented 1 year ago

[ci-build][force-full-build]

sofabot commented 1 year ago

[ci-depends-on] detected during build #17.

To unlock the merge button, you must

fredroy commented 1 year ago

[ci-build][force-full-build]

sofabot commented 1 year ago

[ci-depends-on] detected during build #18.

To unlock the merge button, you must

hugtalbot commented 1 year ago

We are good to go thanks to @fredroy do not mind the build dashboard is not displaying the right builds, e.g. for windows take a look at : https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-2890/18/CI_CONFIG=windows_vs2019,CI_PLUGINS=options,CI_TYPE=release/

LGTM when you agree dear reviewers!

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #19.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #20.

To unlock the merge button, you must

hugtalbot commented 1 year ago

this one was ready right @fredroy ?

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

fredroy commented 1 year ago

All green, ready