Closed hugtalbot closed 1 year ago
@hugtalbot To be enabled on CI ? I'm pretty confident for BeamAdapter but not for Caribou.
@guparan yes for BA, since I will remove Caribou from this PR this answers your question :)
[ci-build][with-all-tests]
https://www.sofa-framework.org/dash/?branch=origin/PR-2890 :fire: :fire: :fire: :fire: :fire: :fire: :fire:
It appears that Damien anticipated it: https://github.com/sofa-framework/BeamAdapter/pull/11
[ci-build][with-all-tests]
Still some compilation errors left
hey @guparan @alxbilger
after investigation, the problem is the same than the one identified in #2927
the lib is generated in build/applications/plugins/BeamAdapter/lib/ and no example from BeamAdapter is also available
moreover, when I do ninja install
only BeamAdapter get installed in its own location (build/applications/plugins/BeamAdapter/linstall/)
do you have any idea what's going on @guparan ?
Here is the fix: https://github.com/SofaDefrost/SoftRobots/pull/147
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/12]
[ci-build][with-all-tests]
[ci-build][force-full-build][with-all-tests]
[ci-build][force-full-build][with-all-tests]
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #13.
To unlock the merge button, you must
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #14.
To unlock the merge button, you must
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #15.
To unlock the merge button, you must
[ci-build][force-full-build]
[ci-depends-on] detected during build #16.
To unlock the merge button, you must
[ci-build][force-full-build]
[ci-depends-on] detected during build #17.
To unlock the merge button, you must
[ci-build][force-full-build]
[ci-depends-on] detected during build #18.
To unlock the merge button, you must
We are good to go thanks to @fredroy do not mind the build dashboard is not displaying the right builds, e.g. for windows take a look at : https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-2890/18/CI_CONFIG=windows_vs2019,CI_PLUGINS=options,CI_TYPE=release/
LGTM when you agree dear reviewers!
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #19.
To unlock the merge button, you must
[ci-depends-on] detected during build #20.
To unlock the merge button, you must
this one was ready right @fredroy ?
[ci-build][force-full-build][with-all-tests]
All green, ready
BeamAdapter shall now be fetchable from SOFA CMake configuration
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if