Closed hugtalbot closed 1 year ago
[ci-build][with-all-tests]
.. wonder if the PR name includes enough acronyms .. 🤔
... it feels like the french administration 🥸
As you renamed the BilateralInteractionConstraint, you will need to recreate/regenerate regression tests associated too 🤫
Duplicated code should be factorized, and naming of data should be shorter
[ci-depends-on] detected during build #6.
To unlock the merge button, you must
[ci-depends-on] detected during build #7.
To unlock the merge button, you must
Renaming of data, factorization of the code done dear reviewers @fredroy @alxbilger
[ci-depends-on] detected during build #8.
To unlock the merge button, you must
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #9.
To unlock the merge button, you must
[ci-depends-on] detected during build #10.
To unlock the merge button, you must
[ci-depends-on] detected during build #11.
To unlock the merge button, you must
[ci-depends-on] detected during build #12.
To unlock the merge button, you must
Create separate functions in buildSystem. Avoid using else function with the d_resolutionMethod. Add a regression scene with unbuilt.
[ci-depends-on] detected during build #13.
To unlock the merge button, you must
review taken into account @alxbilger
[ci-build][force-full-build][with-all-tests]
[ci-depends-on] detected during build #14.
To unlock the merge button, you must
🟢🚦🟢
Based on @ziqiu-zeng implementation, this adds the Non-smooth Non-linear Conjugate Gradient (NNCG) as an alternative to the Projective Gauss Seidel (PGS) as NLCP solver in the GenericConstraintSolver.
resolutionMethod
is added with options: "ProjectedGaussSeidel", "UnbuiltGaussSeidel" or "NonsmoothNonlinearConjugateGradient" and 3 associated examples are provided for each option.schemeCorrection
was also deprecated and removed.Documentation updated: https://github.com/sofa-framework/doc/pull/74
.. wonder if the PR name includes enough acronyms .. :thinking:
[ci-depends-on https://github.com/sofa-framework/Regression/pull/27]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if