sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
871 stars 297 forks source link

[All] Lifecycle update before v22.06 #3090

Closed guparan closed 1 year ago

guparan commented 1 year ago

PointConstraint is removed. serr/sout/sendl are removed. A lot of headers will now trigger the SOFA_DISABLED_HEADER error if included.

Please review, I may have done bad/brutal things.

[ci-depends-on https://github.com/sofa-framework/Registration/pull/3] [ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/268]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

fredroy commented 1 year ago

it seems some plugins are still using serr/sendl....

fredroy commented 1 year ago

[ci-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

fredroy commented 1 year ago

I made my own requested changes 😎

damienmarchal commented 1 year ago

Of course the PR will be breaking and we will need to update our code base. But this is all for the good.

Clearly congratulation @SofaFramework for such high quality management of software evolution.

So if I understand correctly, this will be merge into master the day after the official release of v22.06 right ?

fredroy commented 1 year ago

Of course the PR will be breaking and we will need to update our code base. But this is all for the good.

Clearly congratulation @SofaFramework for such high quality management of software evolution.

So if I understand correctly, this will be merge into master the day after the official release of v22.06 right ?

It should be breaking for some yes (the ones who did not do the change of the things flagged deprecated the last version and marked removed now, like the use of sout/serr/sendl) But it should be merged just before releasing actually, now is the code of v22.06

guparan commented 1 year ago

Wow thanks @fredroy for the changes :muscle:

sofabot commented 1 year ago

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

hugtalbot commented 1 year ago

We're ready for a clean v22.06 !! :tada:

hugtalbot commented 1 year ago

@guparan @fredroy there is still 66 regressions on Ubuntu..

maybe a [ci-build][force-full-build][with-all-tests] will help

sofabot commented 1 year ago

[ci-depends-on] detected during build #14.

To unlock the merge button, you must

sofabot commented 1 year ago

[ci-depends-on] detected during build #15.

To unlock the merge button, you must

guparan commented 1 year ago

Last [ci-build] to unlock the merge button

sofabot commented 1 year ago

[ci-depends-on] detected during build #16.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 1 year ago

should we activate the tests on this PR?

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #17.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

guparan commented 1 year ago

Dashboard is down but status checks are green. Soooo ... ready?

sofabot commented 1 year ago

[ci-depends-on] detected during build #18.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #19.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

fredroy commented 1 year ago

[ci-build][force-full-build][with-all-tests]

sofabot commented 1 year ago

[ci-depends-on] detected during build #20.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1: