[SofaKernel] FIX Mat::transpose() and Mat::invert()

[marques-bruno]

when passing "this" as argument, forcing object copy to avoid unexpected results Fixes #280

---

This PR:

• [x] builds with SUCCESS for all platforms on the CI.
• [x] does not generate new warnings.
• [x] does not generate new unit test failures.
• [x] does not generate new scene test failures.
• [x] does not break API compatibility.
• [x] is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

[marques-bruno]

Not a big fan of the reinterpret_cast in the transpose() method, but it's the only way to check wether or not a copy is needed...

[damienmarchal]

[ci-build]

[hugtalbot]

if you agree with this fix @fjourdes and @maxime-tournier , we will merge this as soon as it builds

[marques-bruno]

@maxime-tournier I believe the last commits takes your input into consideration (if I didn't miss anything) Looking forward your feedback

[guparan]

Any idea why building acd79fe caused more than 20 new unit test failures?

[damienmarchal]

[ci-build]

[damienmarchal]

[ci-build]

[marques-bruno]

PR ready?

[hugtalbot]

Hey @lagarkane There's still 22 new failures of the tests. Is that normal? Looks your commit : 092b19f did it

[guparan]

The 20 new unit tests failures are still there, certainly caused by 092b19fd8e922d155a459de09f002f1815ce9a16.

[marques-bruno]

I take a look

[hugtalbot]

[ci-build]

[marques-bruno]

Hum... I messed up somehow in my previous commit. Did a pull -r and everyting went to hell for some reason... I have 689 files with changes in the PR, which is quite aweful for a small modification in 2 files... How could I fix this? :/ My apologies

[marques-bruno]

Hi dear reviewers, I'm waiting for the ci-build, but I believe that the problems are now solved, and the fix now comes with a few unit tests =) @matthieu-nesme I also restored the static_assert that I previously removed so the code is not only better. Any other suggestion?

[hugtalbot]

@matthieu-nesme is it ok for you? we would like to merge the PR today if possible

[guparan]

Hi @lagarkane, is this finally ready? :-)

[marques-bruno]

I believe it is now! @matthieu-nesme , everything ok?

[damienmarchal]

[ci-build] (to sync with the latest merge of GIL.