Open hugtalbot opened 11 months ago
only the MeshMatrixMass to go @damienmarchal and .. soon goodbye doUpdateInternal !
trackInternalData
to remove
[ci-build][with-all-tests]
only the MeshMatrixMass to go @damienmarchal and .. soon goodbye doUpdateInternal !
I like your definition of "soon" 😆
Is this->trackInternalData(d_vertexMass);
still necessary? @hugtalbot
Similar feature is merged for the ConstantForceField in #3924. It adds separate callbacks for each data but a hacky flag allows to avoid data cross-dependency by de-activating all inputs non-set at the initialization. It could be done here as well but a more robust implementation (Data, callback) could be found.
Add a unit test to make sure that no data cross-dependency is triggered. Manual test as well.
it seems from the CI that many tests and scene examples are using UniformMass without any input mass info .. :clown_face: :japanese_goblin:
[ci-build][with-all-tests]
[ci-build][with-all-tests]
[ci-depends-on] detected during build #13.
To unlock the merge button, you must
@hugtalbot Could you explain why this PR triggers errors when the mass does define any parameter?
[ci-depends-on] detected during build #14.
To unlock the merge button, you must
[ci-depends-on] detected during build #15.
To unlock the merge button, you must
[ci-depends-on] detected during build #16.
To unlock the merge button, you must
[ci-depends-on] detected during build #17.
To unlock the merge button, you must
[ci-depends-on] detected during build #18.
To unlock the merge button, you must
In the spirit of #3900 and following #3924, this PR applies the change on the UniformMass.
To be noted, the
componentState
must be added to trigger the callback (done inaddMDx()
,addMToMatrix
,accFromF
andbuildMassMatrix
)[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/272] [ci-depends-on https://github.com/sofa-framework/Registration/pull/14]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if