[Mass] Replace doUpdateInternal by callback: MeshMatrixMass

hugtalbot commented 11 months ago

In the spirit of #3900 and following #3924, this PR applies the change on the MeshMatrixMass.

To be noted:

the componentState must be added to trigger the callback (done in addMDx(), addMToMatrix, accFromF and buildMassMatrix)
this PR does not solve the problem of circular dependency referred in #2173

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

hugtalbot commented 11 months ago

trackInternalData to remove

fredroy commented 11 months ago

[ci-build][with-all-tests]

hugtalbot commented 1 month ago

Similar feature is merged for the ConstantForceField in #3924. It adds separate callbacks for each data but a hacky flag allows to avoid data cross-dependency by de-activating all inputs non-set at the initialization. It could be done here as well but a more robust implementation (Data, callback) could be found.

Add a unit test to make sure that no data cross-dependency is triggered. Manual test as well.

sofa-framework / sofa

[Mass] Replace doUpdateInternal by callback: MeshMatrixMass #3928