sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
871 stars 297 forks source link

[Lagrangian.Correction] Add callbacks to check zero compliance #4205

Closed hugtalbot closed 4 months ago

hugtalbot commented 7 months ago

I can't add much more than this title

Fix #4202

[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/247] [ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/258]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

hugtalbot commented 7 months ago

Reviews finally taken into account :sweat_smile:

fredroy commented 6 months ago

[ci-build][with-all-tests]

fredroy commented 6 months ago

@hugtalbot Build OK. FIXME: 0 unit, 30 scenes, 12 regressions 🙊

sofabot commented 6 months ago

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

sofabot commented 6 months ago

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

fredroy commented 6 months ago

[ci-build][with-all-tests][force-full-build]

sofabot commented 6 months ago

[ci-depends-on] detected during build #9.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 6 months ago

[ci-depends-on] detected during build #10.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 6 months ago

[ci-depends-on] detected during build #11.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 6 months ago

[ci-build][with-all-tests]

sofabot commented 6 months ago

[ci-depends-on] detected during build #12.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 6 months ago

I let the reviewers decide whether this commit is desired or not, cause it is not necessary to fix the CI

fredroy commented 6 months ago

@hugtalbot will you update the regression references in an other PR ? 🙊

And there is scene test still failing on Python3 (ReadTheDocs_Example.py 😅)

sofabot commented 6 months ago

[ci-depends-on] detected during build #13.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 6 months ago

[ci-depends-on] detected during build #14.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 6 months ago

[ci-depends-on] detected during build #15.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 5 months ago

[ci-depends-on] detected during build #16.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 5 months ago

[ci-depends-on] detected during build #17.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 5 months ago

[ci-build]

sofabot commented 5 months ago

[ci-depends-on] detected during build #18.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 5 months ago

[ci-depends-on] detected during build #19.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

fredroy commented 5 months ago

[ci-build][with-all-tests]

sofabot commented 5 months ago

[ci-depends-on] detected during build #20.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 4 months ago

[ci-depends-on] detected during build #21.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 4 months ago

[ci-depends-on] detected during build #22.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 4 months ago

[ci-build][with-all-tests]

sofabot commented 4 months ago

[ci-depends-on] detected during build #23.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

hugtalbot commented 4 months ago

:warning: :warning: :warning: Before merging the PR, I would like to revert the changes done in https://github.com/SofaDefrost/SoftRobots/pull/247 and see if everything now works well

hugtalbot commented 4 months ago

[ci-build][with-all-tests]

sofabot commented 4 months ago

[ci-depends-on] detected during build #24.

To unlock the merge button, you must

sofabot commented 4 months ago

[ci-depends-on] detected during build #25.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 4 months ago

[ci-depends-on] detected during build #26.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1:

sofabot commented 4 months ago

[ci-depends-on] detected during build #27.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! :+1: