[Visual] Fix cmake config - Githubissues

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.

https://www.sofa-framework.org

GNU Lesser General Public License v2.1

871 stars 297 forks source link

[Visual] Fix cmake config #4555

Closed bakpaul closed 2 months ago

bakpaul commented 2 months ago

Remove the find_package(tinyxml2 REQUIRED) because the link is private

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

hugtalbot commented 2 months ago

Note to my future dummy-me: Dependency is present in CMakeLists but having it in Config.cmake.in propagates this dependency to downstream modules, unable to find tinyXML since it's linked privately :+1: