sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
867 stars 296 forks source link

[GUI.Component] Add virtualization for attachment performer #4638

Closed bakpaul closed 2 weeks ago

bakpaul commented 3 weeks ago

Add virtualization layer to attachment performers.

There exists two of them, either using lagrangian based constraints or springs. A common method start_partial already existed that was supposed to add required components and parametrize them to either add bilateral constraint or a spring, but this common mechanism was not link with any virtual inheritance.

I need to handle both performers blindly using this method (start_partial) so I added a virtualization layer that makes more sens than what currently exists. I use it in this PR -> (Sofa.IGTLink PR).

I've also took advantage of this refactoring to rename some attributes that where not following the naming policy, because why not.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

bakpaul commented 3 weeks ago

[ci-build][with-all-tests]

hugtalbot commented 3 weeks ago

Looks good to me but a bit hard to review due to the mix of changes. It would have been easier with two separate PRs