[Spring] Merging StiffSpringForceField and its parent

bakpaul commented 3 weeks ago

StiffSpringForceField is basically an extension of SpringForcefield adding implicit solving. The only added value comes from the ability to define the springs using added data indices1, indices2 and lengths. This mechanism need to also be merged with the current one available in SpringForceField.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

bakpaul commented 3 weeks ago

Let's see this as a starting point of refactoring. This PR does the merge, the code is neither better nor worst than before, it just removes unnecessary duplication.

Still need to replace every iteration of StiffSpringForceField by SpringForceField and fix Cuda extension

bakpaul commented 2 weeks ago

[ci-build][with-all-tests]

bakpaul commented 2 weeks ago

PR is ready for me now. Still need to decide if I should refactor SofaOpenCL or not given the fact that it doesn't compile with the current SOFA's master branch --> to be discussed in the next SOFA-dev meeting.

bakpaul commented 1 week ago

[ci-build][with-all-tests]

hugtalbot commented 5 days ago

[ci-build][with-all-tests]

sofa-framework / sofa

[Spring] Merging StiffSpringForceField and its parent #4649