sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
867 stars 296 forks source link

Sofa compilation in provided docker #4656

Closed majklost closed 2 weeks ago

majklost commented 2 weeks ago

Docker image compilation fail

Hello, I tried to compile the sofa sources by the docker image, everything was fine until failuer:

In file included from /home/sofa/build/Sofa/GUI/Qt/src/sofa/gui/qt/panels/moc_QDocBrowser.cpp:9:
/home/sofa/build/Sofa/GUI/Qt/src/sofa/gui/qt/panels/../../../../../../../../../sources/Sofa/GUI/Qt/src/sofa/gui/qt/panels/QDocBrowser.h:28:10: fatal error: QWebEngineView: No such file or directory
   28 | #include <QWebEngineView>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Sofa/GUI/Qt/CMakeFiles/Sofa.GUI.Qt.dir/build.make:771: Sofa/GUI/Qt/CMakeFiles/Sofa.GUI.Qt.dir/src/sofa/gui/qt/panels/moc_QDocBrowser.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:10544: Sofa/GUI/Qt/CMakeFiles/Sofa.GUI.Qt.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Is there a fix to it ? thanks

majklost commented 2 weeks ago

Bug was resolved by adding QTWebengineWidgets to target

alxbilger commented 2 weeks ago

Hey @majklost,

Could you add more details? Which target? Because it is already added here : https://github.com/sofa-framework/sofa/blob/7ac489fdaaa782a0d3a86fd02cb046d59ca2d784/Sofa/GUI/Qt/CMakeLists.txt#L49

Thanks

majklost commented 2 weeks ago

No problem, I just wanted to announce that I solved it, so devs don’t have to bother with it, I will add solution and close it when I get home.

Have a nice day, Michal

---------- Původní e-mail ---------- Od: Alex Bilger @.> Komu: sofa-framework/sofa @.> Datum: 18.04.2024 09:38:09 Předmět: Re: [sofa-framework/sofa] Sofa compilation in provided docker (Issue

4656)

"

Hey @majklost(https://github.com/majklost),

Could you add more details? Which target? Because it is already added here : https://github.com/sofa-framework/sofa/blob/7ac489fdaaa782a0d3a86fd02cb046d 59ca2d784/Sofa/GUI/Qt/CMakeLists.txt#L49 (https://github.com/sofa-framework/sofa/blob/7ac489fdaaa782a0d3a86fd02cb046d59ca2d784/Sofa/GUI/Qt/CMakeLists.txt#L49)

Thanks

— Reply to this email directly, view it on GitHub (https://github.com/sofa-framework/sofa/issues/4656#issuecomment-2063222869) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AO5ITU2OYXLGAPR3TOEC673Y55Z5VAVCNFSM6AAAAABGKDW75SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGIZDEOBWHE) . You are receiving this because you were mentioned. Message ID: <sofa- @.***>

"

majklost commented 2 weeks ago

Ok, I tried to reproduce it with current master branch and it did no occured, It seems it was a problem of source in version 23.12, if I have time I will try to replicate it with this source branch.