sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
871 stars 297 forks source link

[SofaCUDA] extern template instantiations #4714

Closed alxbilger closed 1 week ago

alxbilger commented 2 weeks ago

The extern template instantiations allows to include SofaCUDA/config.h before ObjectFactor.h. That is why the module name is defined properly in this PR. The extern template instantiations don't act directly on the module name, just the order of includes.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

alxbilger commented 2 weeks ago

[ci-build][with-all-tests]

epernod commented 2 weeks ago

Sorry I don't understand the link between your comment on the factory and the changes in the PR.

alxbilger commented 2 weeks ago

The function getTarget returns an empty string for the 3 components in this PR. The changes in this PR makes it return a valid string

epernod commented 2 weeks ago

ok so if I understand well, adding the template instantiations only in the cpp return empty string by getTarget Stange... from what I remembered there are several collision classes that are instantiate the same way in the plugin....