[Core] Constexprification of VecId - Githubissues

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.

https://www.sofa-framework.org

GNU Lesser General Public License v2.1

934 stars 312 forks source link

[Core] Constexprification of VecId #5082

Open alxbilger opened 1 month ago

alxbilger commented 1 month ago

TVecId can be constexpr
Enumerations are scoped (global variables are declared to keep compatibility with previous unscoped enumeration)
Indices are based on enumerations (no more hard coded indices)
Main states are defined as a global variable
When main states are called, the global variable is read instead of the call of a static function (each time the static function is called, it instantiates a new variable instead of re-use the same).

Main changes are in VecId.h. The rest is trivial changes.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

alxbilger commented 1 month ago

[ci-build][with-all-tests]