[Visual] Move, rename and clean OglCylinderModel - Githubissues

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.

https://www.sofa-framework.org

GNU Lesser General Public License v2.1

934 stars 312 forks source link

[Visual] Move, rename and clean OglCylinderModel #5124

Open alxbilger opened 1 week ago

alxbilger commented 1 week ago

Moved from Sofa.GL.Component.Rendering3D to Sofa.Component.Visual (as it does not depend on OpenGL)
Renamed from OglCylinderModel to CylinderVisualModel
Color was not properly used -> fixed
Cleaning

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

bakpaul commented 1 week ago

[ci-build][with-all-tests]