[runSofa] Experimental : Headless recorder

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.

https://www.sofa-framework.org

GNU Lesser General Public License v2.1

871 stars 297 forks source link

[runSofa] Experimental : Headless recorder #538

Closed ErwanDouaille closed 6 years ago

ErwanDouaille commented 6 years ago

HeadlessRecorder is, as its name suggest, a new gui plugin who allow users to records sofa visualisation without any windows (batch only)

⚠ Linux only ⚠

https://github.com/sofa-framework/sofa/issues/537

This PR:

[x] builds with SUCCESS for all platforms on the CI.
[x] does not generate new warnings.
[x] does not generate new unit test failures.
[x] does not generate new scene test failures.
[x] does not break API compatibility.
[x] is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

ErwanDouaille commented 6 years ago

@guparan @hugtalbot @damienmarchal I think it's ready for the 17.12 release, as an experimental feature.

damienmarchal commented 6 years ago

Congratulation to Erwan.

damienmarchal commented 6 years ago

[ci-build][with-scene-tests]

damienmarchal commented 6 years ago

[ci-build][with-scene-tests]

guparan commented 6 years ago

[ci-build][with-scene-tests]

ErwanDouaille commented 6 years ago

@damienmarchal @hugtalbot , stupid question. How can I write a test for a GUI ? I don't see any tests for qt/glut ... :/

ErwanDouaille commented 6 years ago

@guparan can you enable the HeadlessRecorder plugin ? It looks like this plugin is not turned on on CI :/

guparan commented 6 years ago

Here you go. It may be better to check if FFMPEG and X11 are installed before enabling the plugin. EDIT: I'll add an if block to enable only on Linux, my bad.

ErwanDouaille commented 6 years ago

[ci-build][with-scene-tests]

ErwanDouaille commented 6 years ago

[ci-build][with-scene-tests]

guparan commented 6 years ago

Any idea why it's still failing on Linux VMs? :-(

ErwanDouaille commented 6 years ago

Failures are due to old ffmpeg libraries. They changed the api (10/2015 as I remember). Actually it´s working on a fresh ubuntu 17.10 but not on the old LTS. I don´t remember the ffmpeg version number.

@bcarrez was working on centos and tried to fetch the correct version before pushing it to the ubuntu vm.

ErwanDouaille commented 6 years ago

[ci-build][with-scene-tests]

ErwanDouaille commented 6 years ago

Well, it's now compiling on linux since @bcarrez installed a new version of some ffmpeg libs. The failure on the ubuntu build is due to the lack of X. @damienmarchal @guparan @hugtalbot do we need to test this "gui" ? I means, others gui are not tested and the problem would be the same as we encounter with the headless recorder if we consider testing it.

On centos, we need to install newer version of ffmpeg libs.

bcarrez commented 6 years ago

@ErwanDouaille your remark makes sense. There are several points to be aware of:

installing a X server on the slaves will take time
it may destabilize the build slave (?) (disc space, unforeseen problem running a GUI server on a headless machine,...)
and I agree: if we do it, the next step should be to test all existing GUIs

bcarrez commented 6 years ago

Ahem... configuring a RECENT version of libavcodec and co. is a pain in the... back on Centos. I kindly suggest we disable this feature on centos...

bcarrez commented 6 years ago

With the new exclusion of SOFAGUI_HEADLESS_RECORDER on CentOS, looks like all tests pass correctly. I think that once the dashboard has finished, this PR will be ready to merge.

ErwanDouaille commented 6 years ago

[ci-build]

ErwanDouaille commented 6 years ago

Dreams do come true ... It's green !!!

damienmarchal commented 6 years ago

[ci-build][with-scene-tests]

damienmarchal commented 6 years ago

So @guparan and @hugtalbot do we set this one to ready ?

ErwanDouaille commented 6 years ago

@guparan thanks for the fix