search

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
934 stars 312 forks source link

Rename PlaneROI #90

Closed EulalieCoevoet closed 7 years ago

EulalieCoevoet commented 7 years ago

I think we should rename these components: PlaneROI -> OrientedBoxROI BoxROI -> AlignedBoxROI

Because if I understand correctly what PlaneROI does, it is not what we expect from the component name.

damienmarchal commented 7 years ago

I support any renaming of poorly named component but we will need to conduct the change in a very smooth manner.

hugtalbot commented 7 years ago

Hi, I do not know well the code of the PlaneROI but is it very different from the BoxROI ? Could this "orientation" feature of the Box be defined as a Data of the BoxROI ?

damienmarchal commented 7 years ago

Well Hugo is right...a single box with an orientation parameter would probably make it.

EulalieCoevoet commented 7 years ago

I agree. I will add the "orientation" feature in BoxROI.

damienmarchal commented 7 years ago

There is PR https://github.com/sofa-framework/sofa/pull/108 from @EulalieCoevoet that implements all that.