search

sofacoustics / SOFAtoolbox

SOFA Toolbox (API for Matlab, Octave)
http://sofaconventions.org
European Union Public License 1.2
116 stars 31 forks source link

Wrong default value in headphone convention #48

Closed f-brinkmann closed 2 years ago

f-brinkmann commented 2 years ago

The default entries for the new Variables ReceiverDescriptions and EmitterDescriptions are {''}. However both variables have dimensions 2 x S so the defaults shall be {'';''}.

All other changes are trailing tabs that my editor removes automatically.

isfmiho commented 2 years ago

Should ReceiverDescriptions and EmitterDescriptions have the dimensions [M S], OR [R S] and [E S], respectively?

petibub commented 2 years ago

[M S] per default.

f-brinkmann commented 2 years ago

Thanks for pointing this out. In this case the dimensions not the default should be changed. I just committed this change

isfmiho commented 2 years ago

Thank you Fabian! I think now it matches the standard.