search

sofacoustics / SOFAtoolbox

SOFA Toolbox (API for Matlab, Octave)
http://sofaconventions.org
European Union Public License 1.2
116 stars 31 forks source link

add SOFAresample function #55

Closed davircarvalho closed 1 year ago

davircarvalho commented 2 years ago

adds resampling function for SimpleFreeFieldHRIR and demo code

isfmiho commented 1 year ago

Thank you Davi, can I set both files to EUPL license?

I would adapt the headers as well, to keep a consistent format.

davircarvalho commented 1 year ago

Sure sure I forgot to include it, feel free to modify before accepting the pull request

petibub commented 1 year ago

Hi David, thanks for providing SOFAresample. Works like a charm! A question: why did you include the post-hoc filtering? This makes SOFAresample to SOFAresampleAndFilter somehow... Can we remove the filtering such that potential users do that filtering post hoc by themselves? Or, do you use it widely in your applications (then, I'd prefer to have the filtering selected by a flag)?

davircarvalho commented 1 year ago

@petibub this is how I normally use this function, my thought in leaving the filtering was to avoid undesirable artefacts for less experienced users and students. I agree it makes sense to leave it as an optional flag though

petibub commented 1 year ago

Ah, I understand. What that be OK to have flags 'scale', 'noscale', 'filter', 'nofilter' with 'scale' and 'nofilter' as defaults?