search

sofacoustics / SOFAtoolbox

SOFA Toolbox (API for Matlab, Octave)
http://sofaconventions.org
European Union Public License 1.2
116 stars 31 forks source link

upgrade for MultiSpeakerBRIR #59

Closed petibub closed 1 year ago

petibub commented 1 year ago

Implement in SOFAupgradeConventions() an automatic upgrade of MultiSpeakerBRIR files to SingleRoomSRIR.

Example for such a file: http://sofacoustics.org/data/database/sbsbrir/SBSBRIR_x-0pt5y-0pt5.sofa or http://sofacoustics.org/data/database/thk/BRIR_CR1_KU_MICS_L.sofa

f-brinkmann commented 1 year ago

@petibub MultispeakerBRIR uses the FIRE data type and SingleRoomSRIR uses FIR. I don't see how the upgrade can work and would suggest to upgrade to SingleRoomMIMOSRIR instead.

isfmiho commented 1 year ago

Thank you; I updated the recommendation on sofaconventions.org.

The automatic upgrade will follow with its milestone.

isfmiho commented 1 year ago

In https://github.com/sofacoustics/SOFAtoolbox/tree/master/SOFAtoolbox/test you can find a converter function doing so.

Should it be implemented in SOFAupgradeConventions() and run by default?

petibub commented 1 year ago

Yes, that would be great, i.e., I start SOFAupgradeConventions with the deprecated MultiSpeakerBRIR dataset and SOFAupgradeConventions outputs a valid SingleRoomSRIR dataset.

isfmiho commented 1 year ago

Implemented in SOFA Toolbox v2.1.5 (development branch).

Keep in mind that the function SOFAupgradeConventions() is not called during SOFAload and SOFAsave by default.