sofacoustics / SOFAtoolbox

SOFA Toolbox (API for Matlab, Octave)
http://sofaconventions.org
European Union Public License 1.2
116 stars 31 forks source link

upgrade for SingleRoomDRIR #60

Closed petibub closed 1 year ago

petibub commented 1 year ago

Implement in SOFAupgradeConventions() an automatic upgrade of SingleRoomDRIR files to SingleRoomSRIR.

Example for such a file: http://sofacoustics.org/data/database/thk/DRIR_CR1_VSA_50RS_L.sofa

isfmiho commented 1 year ago

In https://github.com/sofacoustics/SOFAtoolbox/tree/master/SOFAtoolbox/test you can find a converter function doing so.

Should it be implemented in SOFAupgradeConventions() and run by default?

petibub commented 1 year ago

Yes, that would be great, i.e., I start SOFAupgradeConventions with the deprecated SingleRoomDRIR and obtain a valid dataset with SingleRoomSRIR...

isfmiho commented 1 year ago

Implemented in SOFA Toolbox v2.1.5 (development branch).

Keep in mind that the function SOFAupgradeConventions() is not called during SOFAload and SOFAsave by default.