search

sofarocean / sofar-api-client-python

Python Client for Wavefleet
Apache License 2.0
7 stars 5 forks source link

API client should support sensor-data endpoint #10

Closed evanShap closed 1 year ago

evanShap commented 3 years ago

This would allow access of Smart Mooring data via the API client.

sensor-data endpoint is documented here: https://demo.sofarocean.com/api

MeanLowDrew commented 3 years ago

I've started a fork to add this functionality. It is pretty much done, but I would like to test what happens when someone tries to request data from a spotter with no sensors attached. All the spotters I have access to have sensors.

evanShap commented 3 years ago

I've started a fork to add this functionality. It is pretty much done, but I would like to test what happens when someone tries to request data from a spotter with no sensors attached. All the spotters I have access to have sensors.

Hi @MeanLowDrew - I'm happy to test it out. Is the fork up-to-date here?: https://github.com/MeanLowDrew/sofar-api-client-python

MeanLowDrew commented 3 years ago

Great, thanks. Yep that's up to date.

evanShap commented 3 years ago

@MeanLowDrew I believe it works as desired – returns [] for a Spotter without Smart Mooring data.

MeanLowDrew commented 3 years ago

Perfect. It looks like the staging branch is a bit behind master. Which branch should I merge into?

evanShap commented 3 years ago

Go ahead and open PR into master, we'll sync up staging after. Thanks so much!