sofastack / sofa-acts

ACTS is a white box testing framework based on data model drivers.
https://www.sofastack.tech/sofa-acts/docs/Home
Apache License 2.0
305 stars 86 forks source link

Add unit tests for com.alipay.test.acts.object.comparer.impl.MapComparer #15

Closed louismillsdiffblue closed 5 years ago

louismillsdiffblue commented 5 years ago

I've analysed your codebase and noticed that com.alipay.test.acts.object.comparer.impl.MapComparer is not fully tested. I've written some tests with the help of Diffblue Cover for the following methods in this class:

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be happy to look at other classes that you consider important

codecov[bot] commented 5 years ago

Codecov Report

Merging #15 into master will increase coverage by 0.37%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
+ Coverage     46.58%   46.96%   +0.37%     
- Complexity      624      636      +12     
============================================
  Files            56       56              
  Lines          4310     4310              
  Branches        790      790              
============================================
+ Hits           2008     2024      +16     
+ Misses         1870     1855      -15     
+ Partials        432      431       -1
Impacted Files Coverage Δ Complexity Δ
...va/com/alipay/test/acts/object/ActsObjectUtil.java 43.42% <0%> (+1.31%) 11% <0%> (+1%) :arrow_up:
...ay/test/acts/object/comparer/impl/MapComparer.java 83.33% <0%> (+25%) 20% <0%> (+11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84f7422...dd0077d. Read the comment docs.

elseifer commented 5 years ago

I've analysed your codebase and noticed that com.alipay.test.acts.object.comparer.impl.MapComparer is not fully tested. I've written some tests with the help of Diffblue Cover for the following methods in this class:

  • compare()

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be happy to look at other classes that you consider important

Thank you for your contributionIt ! It will help the development of ACTS.