search

sofastack / sofa-ark

SOFAArk is a light-weight，java based classloader isolation framework.
https://www.sofastack.tech/projects/sofa-boot/sofa-ark-readme/
Apache License 2.0
1.56k stars 497 forks source link

plugin 没必要把自己打到lib内，增加了plugin打包的体积 #935

Closed yuandongjian closed 2 months ago

yuandongjian commented 3 months ago

Describe the question or bug

sofa-ark-plugin-maven-plugin插件除了会把当前项目shade到plugin内，还会把当前项目的jar包打包到plugin/lib内。

Expected behavior

期望plugin只保留当前项目的shade，不打包自身jar到plugin/lib内

Screenshots

image

Actual behavior

目前PluginClassLoader会同时包含shade与lib。以上图为例，PluginClassLoader的classpath会同时包含

sample-ark-plugin-0.6.0-ark-plugin.jar!/
sample-ark-plugin-0.6.0-ark-plugin.jar!/sample-ark-plugin-0.6.0.jar!/

因此，可以去掉plugin/lib下自身的jar包，减少plugin体积。

lvjing2 commented 3 months ago

@crazy-pizza 方便提 PR 修复下吗

yuandongjian commented 3 months ago

@lvjing2 可以的，帮忙把这个issue分配给我吧