search

sofastack / sofa-bolt-python

The Python implementation of the SOFABolt protocol.
Apache License 2.0
47 stars 14 forks source link

Refactor service discovery #16

Closed wanderxjtu closed 3 years ago

wanderxjtu commented 3 years ago

Remove mosn client init from client's init. Build seperate Registry classes, so one can choose or build his own service discovery.

codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (f923b46) into master (93ea4a9) will increase coverage by 0.59%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   82.45%   83.05%   +0.59%     
==========================================
  Files          58       60       +2     
  Lines        1835     1835              
==========================================
+ Hits         1513     1524      +11     
+ Misses        322      311      -11
Impacted Files Coverage Δ
anthunder/model/__init__.py 100.00% <ø> (ø)
anthunder/protocol/_response_pkg.py 100.00% <ø> (ø)
anthunder/listener/aio_listener.py 70.96% <33.33%> (ø)
anthunder/listener/base_listener.py 65.90% <33.33%> (-10.69%) :arrow_down:
anthunder/client/aio_client.py 64.94% <55.00%> (ø)
tests/proto/python/SampleService.py 65.00% <66.66%> (+1.84%) :arrow_up:
anthunder/discovery/local.py 76.92% <76.92%> (ø)
anthunder/discovery/mosn/__init__.py 94.73% <85.71%> (ø)
anthunder/__init__.py 100.00% <100.00%> (ø)
anthunder/client/base.py 78.57% <100.00%> (+28.57%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93ea4a9...f923b46. Read the comment docs.