sofastack / sofa-bolt-python

The Python implementation of the SOFABolt protocol.
Apache License 2.0
47 stars 14 forks source link

migrates to modern coroutine syntax. #6

Closed wanderxjtu closed 4 years ago

wanderxjtu commented 4 years ago

Migrates to `async def/await' syntax, drop support on python3.4.

Quote from python doc

Generator-based Coroutines ... Deprecated since version 3.8, will be removed in version 3.10: Use async def instead.

codecov-io commented 4 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.77%. The diff coverage is 72.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage      83%   83.77%   +0.77%     
==========================================
  Files          58       58              
  Lines        1800     1824      +24     
==========================================
+ Hits         1494     1528      +34     
+ Misses        306      296      -10
Impacted Files Coverage Δ
anthunder/listener/aio_listener.py 75.82% <65.21%> (+4.94%) :arrow_up:
anthunder/client/aio_client.py 64.67% <80%> (-0.04%) :arrow_down:
anthunder/command/heartbeat.py 100% <0%> (ø) :arrow_up:
anthunder/command/fail_response.py 100% <0%> (ø) :arrow_up:
tests/test_aio_listener_client.py 98.94% <0%> (+0.02%) :arrow_up:
tests/mysockpool_test/test_poolman.py 98.18% <0%> (+0.03%) :arrow_up:
anthunder/protocol/_sofa_header.py 95.91% <0%> (+0.08%) :arrow_up:
mytracer/_rpc_id.py 92.85% <0%> (+0.17%) :arrow_up:
anthunder/protocol/_package_base.py 98.5% <0%> (+0.2%) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7abcc4e...ae43552. Read the comment docs.