search

sofastack / sofa-bolt

SOFABolt is a lightweight, easy to use and high performance remoting framework based on Netty.
https://www.sofastack.tech/projects/sofa-bolt/
Apache License 2.0
2.44k stars 860 forks source link

MINOR: refactor AbstractConnectionFactory #307

Closed JoeCqupt closed 2 years ago

JoeCqupt commented 2 years ago

maybe AbstractConnectionFactory should not associated with specific protocol. let it's subclass to implement it.

JoeCqupt commented 2 years ago

If you agree that this is a problem. but this modification is incompatible. here is another solution: make a protocol option for configuration

if you not agree with me . please close this PR. thanks