search

sofastack / sofa-bolt

SOFABolt is a lightweight, easy to use and high performance remoting framework based on Netty.
https://www.sofastack.tech/projects/sofa-bolt/
Apache License 2.0
2.44k stars 860 forks source link

improve: RpcInvokeCallbackListener resolve response #336

Open JoeCqupt opened 10 months ago

JoeCqupt commented 10 months ago

Why make this change?

The code for resolve response is duplicated。

replace duplicated code by using RpcResponseResolver.resolveResponseObject method

Summary by CodeRabbit

JoeCqupt commented 10 months ago

@chuailiwu PTAL

@OrezzerO @nobodyiam

coderabbitai[bot] commented 5 months ago

Walkthrough

The recent changes encompass a variety of improvements and additions across multiple files, focusing on enhancing callback handling, updating dependencies, refining connection status checks, and adding new test cases. Key modifications include refactoring the CallbackTask class for better error handling and callback logic, updating Maven dependencies in pom.xml, and introducing new methods and tests to ensure robust functionality and improved code coverage.

Changes

File(s) Summary of Changes
src/.../RpcInvokeCallbackListener.java Refactored CallbackTask class to improve exception handling, error messages, and callback logic.
.github/workflows/release.yml Added a new GitHub Actions workflow for building and releasing the project using Maven.
pom.xml Updated versions of several dependencies and plugins.
src/.../BaseRemoting.java Renamed defalutCommandFactory to commandFactory and updated related methods.
src/.../Connection.java Enhanced isFine() method to include a check for the closed status.
src/.../InvokeContext.java Added RecordContext field and related method.
src/.../RemotingContext.java Implemented Cloneable interface and added write, flush, and clone methods.
src/.../RpcCommandHandler.java Modified run method to clone ctx before processing.
src/.../RpcRequestProcessor.java Added try-finally block for recording start and stop, and handled exceptions during response serialization.
src/.../SerializerManager.java Introduced ReentrantLock for thread safety when retrieving serializers.
src/test/.../ConnectionTest.java Added testIsFine() method to enhance connection handling tests.
src/test/.../ExceptionTest.java Introduced testGetBizClassLoaderException1() to test exception handling in getBizClassLoader().
src/test/.../RpcCommandHandlerTest.java Added testHandleCommand() and MockUserProcessors class to test RPC command handling.
src/test/.../ClassCustomSerializerTest.java Added testResponseSerialThrowable() for testing Throwable serialization during response.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant RpcCommandHandler
    participant RemotingContext
    participant ProcessMethod

    User->>RpcCommandHandler: Invoke run()
    RpcCommandHandler->>RemotingContext: Clone ctx
    RpcCommandHandler->>ProcessMethod: Call process(ctx.clone(), m)
    ProcessMethod-->>RpcCommandHandler: Return result
    RpcCommandHandler-->>User: Return response

Poem

In lines of code, where logic flows,
Callbacks dance, and error shows.
Dependencies updated, secure and tight,
Connections checked with all their might.
Tests abound, ensuring grace,
In our code, no flaws we trace.
🐇✨ Code refined, a joyous sight!

[!WARNING]

Review ran into problems

Problems (1) * Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
JoeCqupt commented 5 months ago

It's amazing, I feel like this CI will randomly fail

JoeCqupt commented 3 months ago

这个CI有问题，线下跑的单测没问题，CI跑的就报错

线下：

image

CI： https://github.com/sofastack/sofa-bolt/actions/runs/9377858022/job/25820076402?pr=336#step:5:1472

image